Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Gazebo Ionic in tutorial images #3196

Merged
merged 1 commit into from
Jan 4, 2025
Merged

Use Gazebo Ionic in tutorial images #3196

merged 1 commit into from
Jan 4, 2025

Conversation

sea-bass
Copy link
Contributor

@sea-bass sea-bass commented Jan 4, 2025 •
edited
Loading

Description

Seems like Rolling has now shifted to using Gazebo Ionic... seeing if this fixes the build. (EDIT: it does.)

Checklist

  • Required by CI: Code is auto formatted using clang-format
  • Extend the tutorials / documentation reference
  • Document API changes relevant to the user in the MIGRATION.md notes
  • Create tests, which fail without this PR reference
  • Include a screenshot if changing a GUI
  • While waiting for someone to review your request, please help review another open pull request to support the maintainers

@sea-bass sea-bass mentioned this pull request Jan 4, 2025
Merged
2 tasks
@sea-bass sea-bass requested a review from mikeferguson January 4, 2025 03:38
@codecov-commenter
Copy link

codecov-commenter commented Jan 4, 2025 •
edited
Loading

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.00%. Comparing base (a61d973) to head (9f307c1).
Report is 1 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

❗ There is a different number of reports uploaded between BASE (a61d973) and HEAD (9f307c1). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (a61d973) HEAD (9f307c1)
2 1
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #3196       +/-   ##
==========================================
- Coverage   46.00%   0.00%   -45.99%     
==========================================
  Files         714      75      -639     
  Lines       62302    8829    -53473     
  Branches     7532    1456     -6076     
==========================================
- Hits        28656       0    -28656     
+ Misses      33481    8829    -24652     
+ Partials      165       0      -165

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sea-bass sea-bass requested a review from sjahr January 4, 2025 03:55
@sea-bass
Copy link
Contributor Author

sea-bass commented Jan 4, 2025

Rolling CI fixed in #3197

@sea-bass sea-bass mentioned this pull request Jan 4, 2025
Merged
6 tasks
@sea-bass sea-bass enabled auto-merge January 4, 2025 04:41
@sea-bass sea-bass disabled auto-merge January 4, 2025 04:41
@sea-bass sea-bass merged commit 3268f16 into main Jan 4, 2025
19 of 22 checks passed
@sea-bass sea-bass deleted the gz-ionic-in-image branch January 4, 2025 05:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikeferguson mikeferguson mikeferguson approved these changes

@sjahr sjahr Awaiting requested review from sjahr

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sea-bass @codecov-commenter @mikeferguson